[6.x] Support storing meta data as content#11998
Open
godismyjudge95 wants to merge 8 commits intostatamic:6.xfrom
Open
[6.x] Support storing meta data as content#11998godismyjudge95 wants to merge 8 commits intostatamic:6.xfrom
godismyjudge95 wants to merge 8 commits intostatamic:6.xfrom
Conversation
Contributor
Author
|
I might need some help fixing these tests; they are working on my Windows machine. It might be a UNIX path issue? |
Member
|
No problem, we'll handle them. 👍 Thanks for the PR |
Contributor
|
@godismyjudge95 its because line 326 (metaPath) has a ltrim() - it seems to be trying to make the path relative. Updating the function to something like this seems to ensure the tests pass: public function metaPath()
{
if (config('statamic.assets.meta_as_content')) {
return implode('/', [
Stache::store('assets')->directory(),
$this->container()->handle(),
dirname($this->path()),
$this->basename() . '.yaml',
]);
}
$path = implode('/', [
dirname($this->path()),
'.meta',
$this->basename().'.yaml',
]);
return Str::of($path)->replaceFirst('./', '')->ltrim('/')->value();
} |
Contributor
|
What are the chances that this PR finds its way into v6 alpha/beta? 👀 |
duncanmcclean
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has the potential to resolve a lot of issues people have with remote storage of assets.
Related issues:
There are also a lot of Discord discussions about S3 storage being slow. These almost all are resolved by moving the meta data to local storage through the eloquent driver.
The problem with both S3 and eloquent driver storage of meta data is that you lose one of the key features of Statamic - flat file git tracking. This means that if the focal point, custom fields, or other meta data is changed it is not tracked via git.
This PR provides the option to store the asset meta data as content - in the content directory and thus available to be tracked/synced by git.
--
I only provided two tests atm because I am not sure how deeply this needs to be tested as it just changes the paths where things are stored. Let me know if there are other points I need to test at and I will add them.
Also, I could foresee people requesting a command to migrate the asset meta from the standard storage mechanism and back.
Maybe in the future this feature gets turned on by default? 😄